Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9168 )
Change subject: IMPALA-5690: Part 1: Rename ostream operators for thrift types ...................................................................... Patch Set 8: (1 comment) > Patch Set 8: > > (1 comment) > > > > Patch Set 5: > > > > > > Since this is a very large, complicated patch, is it possible to > > break it up to make it easier to review? > > > > > > In particular, I think that all of the changes around '<<' could > > be done in an initial patch, and then have a followup patch that > > contains the actual version bump and other things. > > > > I've split it. The part 2 is at https://gerrit.cloudera.org/c/9300/. > > Thanks for breaking this up. Much easier to wrap my head around now. > > What was the reason for not going with Henry's suggestion on the JIRA to > patch thrift not to emit '<<'? Thrift is still changing this operator<< in 0.11, adding enum types. If we patch it now we may need to rework it on every thrift upgrade. Generally I think it's unnecessary to patch a library only for a name conflict. http://gerrit.cloudera.org:8080/#/c/9168/8/be/src/runtime/coordinator-backend-state.cc File be/src/runtime/coordinator-backend-state.cc: http://gerrit.cloudera.org:8080/#/c/9168/8/be/src/runtime/coordinator-backend-state.cc@64 PS8, Line 64: DCHECK(host_ == instance_params->host); // all hosts must be the same > Why was thing change made? DCHECK_EQ uses operator << to print the value of lhs and rhs. Operator << is removed and the error message won't include the values after this change. If it matters I can do it manually. Another option is to revert this line in part 2, using the operator << defined by thrift. -- To view, visit http://gerrit.cloudera.org:8080/9168 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9c303997411237e988ef960157f781776f6fcb60 Gerrit-Change-Number: 9168 Gerrit-PatchSet: 8 Gerrit-Owner: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Comment-Date: Tue, 13 Feb 2018 22:09:10 +0000 Gerrit-HasComments: Yes
