Thomas Tauber-Marshall has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9283 )

Change subject: Add KuduDataTypeToColumnType default case
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9283/1/be/src/exec/kudu-util.cc
File be/src/exec/kudu-util.cc:

http://gerrit.cloudera.org:8080/#/c/9283/1/be/src/exec/kudu-util.cc@196
PS1, Line 196:     default: return ColumnType(PrimitiveType::INVALID_TYPE);
Excluding the default here was an intentional choice so that the compiler will 
tell us if we've missed something.

I understand that without the 'default' we'll get a compiler error when we bump 
the toolchain version to pull in the new Kudu client, but I would prefer that 
we just include a 'case DECIMAL' in that same patch, rather than losing the 
compiler check here.



--
To view, visit http://gerrit.cloudera.org:8080/9283
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f7d9e16070b66274107a2bff52cbe8f3ae9b8f1
Gerrit-Change-Number: 9283
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <granthe...@gmail.com>
Gerrit-Reviewer: Grant Henke <granthe...@gmail.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com>
Gerrit-Comment-Date: Mon, 12 Feb 2018 18:38:46 +0000
Gerrit-HasComments: Yes

Reply via email to