Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9283 )
Change subject: Add KuduDataTypeToColumnType default case ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9283/1/be/src/exec/kudu-util.cc File be/src/exec/kudu-util.cc: http://gerrit.cloudera.org:8080/#/c/9283/1/be/src/exec/kudu-util.cc@196 PS1, Line 196: default: return ColumnType(PrimitiveType::INVALID_TYPE); > Excluding the default here was an intentional choice so that the compiler w It didn't appear intentional given there was a "fall through" to a `return ColumnType(PrimitiveType::INVALID_TYPE);`. This is also the only "conversion" like this without a default statement, including conversions the other direction going from Impala type to Kudu type. I also looked at the fe "toImpalaType" behavior which also uses a catch all default statement. -- To view, visit http://gerrit.cloudera.org:8080/9283 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f7d9e16070b66274107a2bff52cbe8f3ae9b8f1 Gerrit-Change-Number: 9283 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Mon, 12 Feb 2018 18:47:46 +0000 Gerrit-HasComments: Yes
