Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9239 )
Change subject: IMPALA-6258: Uninitialized tuple pointers in row batch for empty rows ...................................................................... Patch Set 3: (4 comments) Logic of the patch looks good to me, did a final pass for stylistic nits. I'll +2 once those are fixed. http://gerrit.cloudera.org:8080/#/c/9239/3/be/src/exec/hdfs-scanner.cc File be/src/exec/hdfs-scanner.cc: http://gerrit.cloudera.org:8080/#/c/9239/3/be/src/exec/hdfs-scanner.cc@228 PS3, Line 228: // Let's not leave tuple ptrs uninitialized. Can you add the JIRA to this comment to better explain the consequences of not doing this? http://gerrit.cloudera.org:8080/#/c/9239/3/be/src/exec/kudu-scanner.cc File be/src/exec/kudu-scanner.cc: http://gerrit.cloudera.org:8080/#/c/9239/3/be/src/exec/kudu-scanner.cc@259 PS3, Line 259: // Initialize tuple ptrs to a dummy non-null value Can you add the JIRA there too? http://gerrit.cloudera.org:8080/#/c/9239/3/be/src/runtime/tuple.h File be/src/runtime/tuple.h: http://gerrit.cloudera.org:8080/#/c/9239/3/be/src/runtime/tuple.h@89 PS3, Line 89: Poison This should either be lower-case if we're treating it as a variable or upper-case if we're treating it as a constant. It's a weird edge case but it feels like it should be a constant to me. http://gerrit.cloudera.org:8080/#/c/9239/3/be/src/runtime/tuple.h@91 PS3, Line 91: void Init(int size) { Unnecessary formatting change here. -- To view, visit http://gerrit.cloudera.org:8080/9239 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I298122aaaa7e62eb5971508e0698e189519755de Gerrit-Change-Number: 9239 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 12 Feb 2018 19:48:17 +0000 Gerrit-HasComments: Yes
