Nithya Janarthanan has posted comments on this change. ( http://gerrit.cloudera.org:8080/9273 )
Change subject: IMPALA-5139: Update mvn-quiet.sh to print execution content to log file ...................................................................... Patch Set 5: > Patch Set 1: > > I think this is a good start, but this patch be improved again. I concede too > that the IMPALA-5139 description doesn't provide full context. Let me provide > some now: > > - I think mvn-quiet.sh capturing of mvn INFO output should go into one or > more files rooted in $IMPALA_LOG_DIR. This will let Jenkins jobs which tend > to look in that place collect the mvn logs, too. > > - The working directory and args matter. You can see that's already captured > L25-26 of this file, but I think we need that info alongside all the maven > output and be written to the log. > > - More than one thing calls mvn-quiet.sh. You need a strategy for appending > to a log file or writing multiple log files. tee -a might be of assistance > here. Adding my responses to the review comments long after I have addressed them, - Thanks Michael. I have addressed your comments to --- Write the mvn outputs to a single log file --- log file located in $IMPALA_HOME/logs/mvn -- To view, visit http://gerrit.cloudera.org:8080/9273 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I475b17a4dccfa624dda61402491b461c53473f8b Gerrit-Change-Number: 9273 Gerrit-PatchSet: 5 Gerrit-Owner: Nithya Janarthanan <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Nithya Janarthanan <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Thu, 15 Feb 2018 14:45:51 +0000 Gerrit-HasComments: No
