David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9291 )
Change subject: IMPALA-6508: add KRPC test flag ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/9291/5/tests/common/custom_cluster_test_suite.py File tests/common/custom_cluster_test_suite.py: http://gerrit.cloudera.org:8080/#/c/9291/5/tests/common/custom_cluster_test_suite.py@137 PS5, Line 137: if pytest.config.option.test_krpc: : cmd.append("--use_krpc") > I wonder if that's on purpose, would you like me to ask on dev@? Not sure I'm totally following (haven't really looked much at the custom cluster tests), but for what it's worth, I think that it's best that tests be 100% repeatable, and not vary according to differences between one dev environment and another. If we're specifically testing that certain custom args work, then we should (I think) exclude TEST_START_CLUSTER_ARGS. http://gerrit.cloudera.org:8080/#/c/9291/8/tests/custom_cluster/test_krpc_mem_usage.py File tests/custom_cluster/test_krpc_mem_usage.py: http://gerrit.cloudera.org:8080/#/c/9291/8/tests/custom_cluster/test_krpc_mem_usage.py@64 PS8, Line 64: @SkipIf.not_krpc If this applies to all the tests here (it appears to), then I think SkipIf decorator can be applied to the entire test class. -- To view, visit http://gerrit.cloudera.org:8080/9291 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie01a5de2afac4a0f43d5fceff283f6108ad6a3ab Gerrit-Change-Number: 9291 Gerrit-PatchSet: 8 Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Thu, 15 Feb 2018 17:32:18 +0000 Gerrit-HasComments: Yes
