Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9344 )
Change subject: IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/9344/1/be/src/exec/exchange-node.cc File be/src/exec/exchange-node.cc: http://gerrit.cloudera.org:8080/#/c/9344/1/be/src/exec/exchange-node.cc@159 PS1, Line 159: Status ExchangeNode::GetNext(RuntimeState* state, RowBatch* output_batch, bool* eos) { > I thought we discussed this in the past and the conclusion was that we can Oops, you are right. http://gerrit.cloudera.org:8080/#/c/9344/1/be/src/runtime/row-batch.cc File be/src/runtime/row-batch.cc: http://gerrit.cloudera.org:8080/#/c/9344/1/be/src/runtime/row-batch.cc@123 PS1, Line 123: BufferPool::BufferHandle* tuple_ptrs_buffer = &(tuple_ptrs_info_->buffer); > Mostly 8KB I suspect if there are 1024 rows and 1 tuple (e.g. from scan nod Seems ok to me. -- To view, visit http://gerrit.cloudera.org:8080/9344 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If4b1a45f68b9df0d3b539511e15aff15700246f2 Gerrit-Change-Number: 9344 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 16 Feb 2018 21:22:23 +0000 Gerrit-HasComments: Yes
