Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9300 )
Change subject: IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3 ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/9300/4/be/src/common/init.cc File be/src/common/init.cc: http://gerrit.cloudera.org:8080/#/c/9300/4/be/src/common/init.cc@239 PS4, Line 239: . formatting http://gerrit.cloudera.org:8080/#/c/9300/4/bin/impala-config.sh File bin/impala-config.sh: http://gerrit.cloudera.org:8080/#/c/9300/4/bin/impala-config.sh@75 PS4, Line 75: 40-922a6d71e8 I don't think this is necessary - the toolchain has already been bumped to a version that's more recent than this (in fact, this probably excludes the latest bump in Kudu version which is needed for DECIMAL support, and so this probably doesn't compile if rebased on master). My understanding is that currently the toolchain builds both 0.9.0-p11 (the current thrift version) and 0.9.3-p3 (the new thrift version), which is how we're already building against an updated toolchain without having bumped IMPALA_THRIFT_VERSION below. Correct me if any of that is wrong. -- To view, visit http://gerrit.cloudera.org:8080/9300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I639227721502eaa10398d9490ff6ac63aa71b3a6 Gerrit-Change-Number: 9300 Gerrit-PatchSet: 4 Gerrit-Owner: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Comment-Date: Tue, 20 Feb 2018 21:24:47 +0000 Gerrit-HasComments: Yes
