Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9364 )
Change subject: IMPALA-6275: Fix warn stacktrace in successful CTAS ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9364/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/9364/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@1577 PS1, Line 1577: private void loadSchema(IMetaStoreClient client, Even better, let's separate the loadSchema() part from the loadAllColumnStats() part. * the loadSchema() part really converts an existing msTbl to our internal schema; we only need client to get the nullPartitionKeyValue_, so probably we can change loadSchema() to only take the msTbl and nothing else as param * loadAllColumnStats() really needs a client because it tries to RPC to the HMS; this is a good indication that loadSchema() and loadAlColumnStats() should really be separate -- To view, visit http://gerrit.cloudera.org:8080/9364 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6f07a188458954802fda20e3b3b56280d96e788e Gerrit-Change-Number: 9364 Gerrit-PatchSet: 1 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Comment-Date: Wed, 21 Feb 2018 06:08:10 +0000 Gerrit-HasComments: Yes
