Alex Behm has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9364 )

Change subject: IMPALA-6275: Fix warn stacktrace in successful CTAS
......................................................................


Patch Set 4:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/9364/4/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java:

http://gerrit.cloudera.org:8080/#/c/9364/4/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@1254
PS4, Line 1254:         loadAllColumnStats(client);
to preserve the existing behavior exactly:
if (loadTableSchema) {
  loadSchema(msTbl);
  loadAllColumnStats(client);
}


http://gerrit.cloudera.org:8080/#/c/9364/4/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@1569
PS4, Line 1569:    * Loads table schema and column stats from Hive Metastore.
update comment


http://gerrit.cloudera.org:8080/#/c/9364/4/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@2280
PS4, Line 2280:       org.apache.hadoop.hive.metastore.api.Table msTbl) throws 
Exception {
What throws here? If nothing, remove throws.



--
To view, visit http://gerrit.cloudera.org:8080/9364
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f07a188458954802fda20e3b3b56280d96e788e
Gerrit-Change-Number: 9364
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com>
Gerrit-Comment-Date: Thu, 22 Feb 2018 20:44:56 +0000
Gerrit-HasComments: Yes

Reply via email to