Mostafa Mokhtar has posted comments on this change. ( http://gerrit.cloudera.org:8080/9221 )
Change subject: IMPALA-6461 : Micro-optimizations to DataStreamSender::Send ...................................................................... Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/9221/7/be/src/runtime/data-stream-sender.cc File be/src/runtime/data-stream-sender.cc: http://gerrit.cloudera.org:8080/#/c/9221/7/be/src/runtime/data-stream-sender.cc@451 PS7, Line 451: (num_rows - batch_start) > nit: unnecessary parenthesis Done http://gerrit.cloudera.org:8080/#/c/9221/7/be/src/runtime/data-stream-sender.cc@485 PS7, Line 485: (num_rows - batch_start) > Same here Done http://gerrit.cloudera.org:8080/#/c/9221/7/be/src/runtime/krpc-data-stream-sender.cc File be/src/runtime/krpc-data-stream-sender.cc: http://gerrit.cloudera.org:8080/#/c/9221/7/be/src/runtime/krpc-data-stream-sender.cc@668 PS7, Line 668: (num_rows - batch_start) > Same here. Done http://gerrit.cloudera.org:8080/#/c/9221/7/be/src/runtime/krpc-data-stream-sender.cc@702 PS7, Line 702: (num_rows - batch_start) > Same here. Done -- To view, visit http://gerrit.cloudera.org:8080/9221 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I642a9dad531a29d4838a3537ab0e04320a69960d Gerrit-Change-Number: 9221 Gerrit-PatchSet: 7 Gerrit-Owner: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 21 Feb 2018 18:29:56 +0000 Gerrit-HasComments: Yes
