Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9221 )
Change subject: IMPALA-6461 : Micro-optimizations to DataStreamSender::Send ...................................................................... IMPALA-6461 : Micro-optimizations to DataStreamSender::Send While analyzing performance of partition exchange operator, I noticed that there is dependency and a function call per row in the hot path. Optimizations in this change are: 1) Remove the data dependency between computing the hash and the channel 2) Inline DataStreamSender::Channel::AddRow 3) Save partition_exprs_.size() to save a couple of instructions This translates to improving CPI for DataStreamSender::Send by 10% Change-Id: I642a9dad531a29d4838a3537ab0e04320a69960d Reviewed-on: http://gerrit.cloudera.org:8080/9221 Reviewed-by: Mostafa Mokhtar <[email protected]> Tested-by: Impala Public Jenkins --- M be/src/runtime/data-stream-sender.cc M be/src/runtime/krpc-data-stream-sender.cc M be/src/runtime/row-batch.h 3 files changed, 110 insertions(+), 48 deletions(-) Approvals: Mostafa Mokhtar: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/9221 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I642a9dad531a29d4838a3537ab0e04320a69960d Gerrit-Change-Number: 9221 Gerrit-PatchSet: 9 Gerrit-Owner: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
