Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/9271 )
Change subject: IMPALA-6497: add "Last row fetched" and AC events ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/9271/9/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: http://gerrit.cloudera.org:8080/#/c/9271/9/be/src/runtime/coordinator.cc@1097 PS9, Line 1097: query_events_->MarkEvent("Released admission control resources"); nit: I stumbled upon this one while going through recent commits. I have a qq, wouldn't this be confusing if --disable_admission_control=true, especially since marked events show up in query profiles. Also, should this method return early (without logging in L1091) if (ExecEnv::GetInstance()->admission_controller() == nullptr)? -- To view, visit http://gerrit.cloudera.org:8080/9271 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I32a707e4660061e75c86ad967f1fac6f6737da7e Gerrit-Change-Number: 9271 Gerrit-PatchSet: 9 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 22 Feb 2018 00:11:52 +0000 Gerrit-HasComments: Yes
