Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9271 )
Change subject: IMPALA-6497: add "Last row fetched" and AC events ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/9271/9/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: http://gerrit.cloudera.org:8080/#/c/9271/9/be/src/runtime/coordinator.cc@1097 PS9, Line 1097: query_events_->MarkEvent("Released admission control resources"); > nit: I stumbled upon this one while going through recent commits. I have a I suppose it's not technically correct, but that's not a configuration that we want to encourage (enabling admission control with no limits gives the same behaviour and is much better tested). We're getting rid of that flag in Impala 3.0: IMPALA-5814. -- To view, visit http://gerrit.cloudera.org:8080/9271 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I32a707e4660061e75c86ad967f1fac6f6737da7e Gerrit-Change-Number: 9271 Gerrit-PatchSet: 9 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 22 Feb 2018 00:34:18 +0000 Gerrit-HasComments: Yes
