Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9401 )
Change subject: IMPALA-6564: avoid scanner thread race leading to query failure ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/9401/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9401/2//COMMIT_MSG@13 PS2, Line 13: cause adding new scan ranges to fail with status CANCELLED. > I don't follow this given this code: initial_ranges_issued_ is set at the start of IssueInitialRanges() before the ranges are actually issued (and there's no locking around it). Effectively now it is preventing scanner threads from starting before GetNext() is called, but doesn't prevent scanner threads from starting before all the ranges are issued. I think there's a better fix in restructuring that bit of logic but I didn't want to start pulling on that bit of thread right now -- To view, visit http://gerrit.cloudera.org:8080/9401 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If1a17b8a3586a2f41988f3da673addf2b4565408 Gerrit-Change-Number: 9401 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 22 Feb 2018 21:01:49 +0000 Gerrit-HasComments: Yes
