Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9367 )
Change subject: IMPALA-6543: Limit RowBatch serialization size to INT_MAX ...................................................................... Patch Set 1: (1 comment) Updated row-batch-serialization-test to test each of the limits. http://gerrit.cloudera.org:8080/#/c/9367/1/be/src/runtime/row-batch.cc File be/src/runtime/row-batch.cc: http://gerrit.cloudera.org:8080/#/c/9367/1/be/src/runtime/row-batch.cc@346 PS1, Line 346: INT_MAX > We've standardised on numeric_limits<int>::max(). I kind of like INT_MAX be Fixed. -- To view, visit http://gerrit.cloudera.org:8080/9367 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b022acdf3bc93912d6d98829b30e44b65890d91 Gerrit-Change-Number: 9367 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 22 Feb 2018 21:35:10 +0000 Gerrit-HasComments: Yes
