Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9367 )
Change subject: IMPALA-6543: Limit RowBatch serialization size to INT_MAX ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/9367/2/be/src/runtime/row-batch.cc File be/src/runtime/row-batch.cc: http://gerrit.cloudera.org:8080/#/c/9367/2/be/src/runtime/row-batch.cc@307 PS2, Line 307: } > how about leaving the DCHECK after the if-stmt, so we still assert for posi Good point, I will put that back in. -- To view, visit http://gerrit.cloudera.org:8080/9367 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b022acdf3bc93912d6d98829b30e44b65890d91 Gerrit-Change-Number: 9367 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 23 Feb 2018 19:02:38 +0000 Gerrit-HasComments: Yes
