Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9441 )
Change subject: IMPALA-6582: fix test_multiline_queries_in_history ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9441/1/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/9441/1/tests/shell/test_shell_interactive.py@220 PS1, Line 220: queries = ["select\n1;--comment", > Hard to say what the original intent of this query was. I would have assume I don't know. I think the new test makes sense, since the comment is included in the history still. Anyway, I added a couple more variations to be sure. I discovered in the process that trailing newlines are stripped as well, so I had to distinguish the input and expected output. The removal of newlines seems a bit wonky but benign. -- To view, visit http://gerrit.cloudera.org:8080/9441 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If917bbc8e87b83c188b6d5e1acad912892b8c6fe Gerrit-Change-Number: 9441 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Sat, 24 Feb 2018 18:18:02 +0000 Gerrit-HasComments: Yes
