Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9441 )
Change subject: IMPALA-6582: fix test_multiline_queries_in_history ...................................................................... IMPALA-6582: fix test_multiline_queries_in_history The semicolon was in the wrong place in one of the test queries and the failure was swallowed silently. This meant that one fewer prompt was displayed than expected. This didn't cause a test failure because the prompt regex also matched the "Connected to host:port" message printed in the shell preamble. I'm unsure why this would cause the test failure but my best theory is that in the failure case, the "Connected" and prompt messages are both buffered when we evaluate the first prompt regex, and the regex swallows up the whole input, rather than just the first instance. Testing: Tightened up the prompt regex and checked that the query actually executed successfully. With these improvements, the broken query text caused a test failure. I looped the test for a while to make sure it was robust. Added a couple of related test cases to make sure we aren't losing coverage. Change-Id: If917bbc8e87b83c188b6d5e1acad912892b8c6fe Reviewed-on: http://gerrit.cloudera.org:8080/9441 Reviewed-by: Alex Behm <alex.b...@cloudera.com> Tested-by: Impala Public Jenkins --- M tests/shell/test_shell_interactive.py 1 file changed, 14 insertions(+), 7 deletions(-) Approvals: Alex Behm: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/9441 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: If917bbc8e87b83c188b6d5e1acad912892b8c6fe Gerrit-Change-Number: 9441 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
