Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9458 )
Change subject: IMPALA-6583: Wait for non-empty catalog update at impalad startup ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/9458/2/fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java File fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java: http://gerrit.cloudera.org:8080/#/c/9458/2/fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java@213 PS2, Line 213: if (newCatalogVersion > INITIAL_CATALOG_VERSION) { > This is subtle and needs an explanation. How can we get an update with INIT I tested this and it seems the statestore sends out empty non-delta topic updates while the catalogd is starting up. I think your fixes are correct, but we should explain with a comment here. -- To view, visit http://gerrit.cloudera.org:8080/9458 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie5f09d03497543f283b39c6186ecfda2e0097c87 Gerrit-Change-Number: 9458 Gerrit-PatchSet: 2 Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 27 Feb 2018 18:23:15 +0000 Gerrit-HasComments: Yes
