Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9458 )
Change subject: IMPALA-6583: Wait for non-empty catalog update at impalad startup ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/9458/3/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/9458/3/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@1123 PS3, Line 1123: // In case of an empty new catalog, the version should still change to reflect the This is a more elaborate version of your previous comment :). The important part to me is that Impalads wait for a catalog update with version > 0 before accepting requests. http://gerrit.cloudera.org:8080/#/c/9458/3/fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java File fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java: http://gerrit.cloudera.org:8080/#/c/9458/3/fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java@519 PS3, Line 519: public void setIsReady(boolean isReady) { As far as I can tell, we can get rid of this function altogether. http://gerrit.cloudera.org:8080/#/c/9458/3/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/9458/3/fe/src/main/java/org/apache/impala/service/Frontend.java@802 PS3, Line 802: * the first non-empty catalog update is received from the statestore. ... the first catalog update with a version > INITIAL_CATALOG_VERSION is received. I think "non-empty" could be misleading because this logic will also work if the catalog is empty. -- To view, visit http://gerrit.cloudera.org:8080/9458 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie5f09d03497543f283b39c6186ecfda2e0097c87 Gerrit-Change-Number: 9458 Gerrit-PatchSet: 3 Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 28 Feb 2018 17:12:18 +0000 Gerrit-HasComments: Yes
