Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9446 )
Change subject: IMPALA-6554: Fix a race in DequeueDeferredRpc() ...................................................................... Patch Set 4: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/9446/3/be/src/runtime/krpc-data-stream-recvr.cc File be/src/runtime/krpc-data-stream-recvr.cc: http://gerrit.cloudera.org:8080/#/c/9446/3/be/src/runtime/krpc-data-stream-recvr.cc@441 PS3, Line 441: int sender_id = ctx->request->sender_id(); : recvr_->mem_tracker()->Consume(ctx->rpc_context->GetTransferSize()); : COUNTER_ADD(recvr_->num_arrived_batches_, 1); : { : lock_guard<SpinLock> l(lock_); : if (UNLIKELY(is_cancelled_)) { : DataStreamService::RespondDefer > I prefer not to enqueue the reply under the lock if possible. Please see re Makes sense. Adding a brief comment pointing that out would be a good idea. I can see how a new reader of the code could get confused otherwise. -- To view, visit http://gerrit.cloudera.org:8080/9446 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4a3b0789633c7b8bc898381d509e2af769f0e069 Gerrit-Change-Number: 9446 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Comment-Date: Thu, 01 Mar 2018 19:36:38 +0000 Gerrit-HasComments: Yes
