Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9446 )
Change subject: IMPALA-6554: Fix a race in DequeueDeferredRpc() ...................................................................... Patch Set 5: Code-Review+2 This looks good. Not for this change, but do we have any way to test for leaks of the service mem tracker? Given that's daemon wide, we probably don't get the benefit of the Close() check for that mem tracker, right? Maybe we should add a DCHECK that whenever the service queue is empty, the service mem tracker has 0 consumption? -- To view, visit http://gerrit.cloudera.org:8080/9446 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4a3b0789633c7b8bc898381d509e2af769f0e069 Gerrit-Change-Number: 9446 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Comment-Date: Thu, 01 Mar 2018 22:06:28 +0000 Gerrit-HasComments: No
