Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9525 )
Change subject: IMPALA-6389: Make '\0' delimited text files work ...................................................................... Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/9525/1/be/src/exec/delimited-text-parser.h File be/src/exec/delimited-text-parser.h: http://gerrit.cloudera.org:8080/#/c/9525/1/be/src/exec/delimited-text-parser.h@29 PS1, Line 29: delimited_tuples comment on what that is. it'd be nice if we used all caps for template args more consistently, but I see we already have template args in this class that don't do that, so okay to ignore. http://gerrit.cloudera.org:8080/#/c/9525/1/be/src/exec/delimited-text-parser.h@51 PS1, Line 51: tuple_delim what should be passed in here when !delimited_tuples? let's at least note in the comment above that this is ignored when !delimited_tuples http://gerrit.cloudera.org:8080/#/c/9525/1/be/src/exec/delimited-text-parser.h@96 PS1, Line 96: /// This function is disabled for non-sequence file parsing. : template <bool process_escapes, bool enabled=true> : typename std::enable_if<!delimited_tuples && enabled, Status>::type why do we need that? http://gerrit.cloudera.org:8080/#/c/9525/1/be/src/exec/delimited-text-parser.h@222 PS1, Line 222: tuple_delim_ how about saying that's valid only when delimited_tuples is true? http://gerrit.cloudera.org:8080/#/c/9525/1/be/src/exec/delimited-text-parser.inline.h File be/src/exec/delimited-text-parser.inline.h: http://gerrit.cloudera.org:8080/#/c/9525/1/be/src/exec/delimited-text-parser.inline.h@55 PS1, Line 55: b why isn't that delimited_tuples? is it something different http://gerrit.cloudera.org:8080/#/c/9525/1/be/src/exec/delimited-text-parser.inline.h@163 PS1, Line 163: tuple_delim_ || (tuple_delim_ do those need to be guarded? http://gerrit.cloudera.org:8080/#/c/9525/1/be/src/exec/delimited-text-parser.inline.h@235 PS1, Line 235: enabled what's that about? -- To view, visit http://gerrit.cloudera.org:8080/9525 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4b6f38cbe3f1036f60efd31a31d82d0cd8f3d2a8 Gerrit-Change-Number: 9525 Gerrit-PatchSet: 1 Gerrit-Owner: Zach Amsden <zams...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 07 Mar 2018 21:00:22 +0000 Gerrit-HasComments: Yes
