Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9525 )
Change subject: IMPALA-6389: Make '\0' delimited text files work ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9525/1/be/src/exec/delimited-text-parser.inline.h File be/src/exec/delimited-text-parser.inline.h: http://gerrit.cloudera.org:8080/#/c/9525/1/be/src/exec/delimited-text-parser.inline.h@163 PS1, Line 163: tuple_delim_ || (tuple_delim_ > I don't follow that. When DELIMITED_TUPLES is false, the comment says tuple I agree the logic here is kind of broken; if tuple_delim_ == field_delim_, this isn't correct for !DELIMITED_TUPLES; however, in practice tuple_delim_ can not be equal to field_delim_ except in the unit test; this is prohibited by the frontend. To compound the matter, the only place this matters, in hdfs-sequence-scanner.cc never checks this value, as by general design, the sequence scanner always knows where the tuple ends and never has to deal with unfinished tuples. This makes me a bit loathe to make the logic here more complicated. A good compromise might be to make this also include DELIMITED_TUPLES as a conjunct, and then add a DCHECK in HasUnfinishedTuples() that DELIMITED_TUPLES is true. -- To view, visit http://gerrit.cloudera.org:8080/9525 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4b6f38cbe3f1036f60efd31a31d82d0cd8f3d2a8 Gerrit-Change-Number: 9525 Gerrit-PatchSet: 1 Gerrit-Owner: Zach Amsden <zams...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zach Amsden <zams...@cloudera.com> Gerrit-Comment-Date: Thu, 15 Mar 2018 18:34:03 +0000 Gerrit-HasComments: Yes
