Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9544 )
Change subject: IMPALA-6500: gracefully handle invalid sched_getcpu() values ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Looks good, up to you if you think we could reduce spamminess. http://gerrit.cloudera.org:8080/#/c/9544/2/be/src/util/cpu-info.cc File be/src/util/cpu-info.cc: http://gerrit.cloudera.org:8080/#/c/9544/2/be/src/util/cpu-info.cc@298 PS2, Line 298: const int MAX_WARNINGS = 100; I think we could cut this down to say 20 or so; if it happens, it is likely to immediately repeat and flood logs. -- To view, visit http://gerrit.cloudera.org:8080/9544 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a118953c175b0aa13762ad11dccce01a4c70032 Gerrit-Change-Number: 9544 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zach Amsden <zams...@cloudera.com> Gerrit-Comment-Date: Thu, 08 Mar 2018 20:25:19 +0000 Gerrit-HasComments: Yes
