Hello Zach Amsden,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9544
to look at the new patch set (#3).
Change subject: IMPALA-6500: gracefully handle invalid sched_getcpu() values
......................................................................
IMPALA-6500: gracefully handle invalid sched_getcpu() values
It appears that in some cases (probably under virtualization) we can get
out-of-range values returned from this function. Handle that case by
warning and modding the value back into range.
Testing:
Manually modified the function to inject a bad CPU ID. Verified that it
logged the warning as expected.
Added a backend test to exercise the code path. In the process,
repurpose perf-counters-test and delete some dead code that it
referenced.
Change-Id: I5a118953c175b0aa13762ad11dccce01a4c70032
---
M be/src/testutil/cpu-util.h
M be/src/util/CMakeLists.txt
M be/src/util/cpu-info.cc
D be/src/util/perf-counters-test.cc
D be/src/util/perf-counters.cc
D be/src/util/perf-counters.h
A be/src/util/sys-info-test.cc
7 files changed, 95 insertions(+), 647 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/9544/3
--
To view, visit http://gerrit.cloudera.org:8080/9544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5a118953c175b0aa13762ad11dccce01a4c70032
Gerrit-Change-Number: 9544
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Zach Amsden <[email protected]>
