Adam Holley has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9276 )

Change subject: IMPALA-6479: Update DESCRIBE to respect column privileges
......................................................................


Patch Set 2:

(7 comments)

Fixed.

http://gerrit.cloudera.org:8080/#/c/9276/2/be/src/service/frontend.h
File be/src/service/frontend.h:

http://gerrit.cloudera.org:8080/#/c/9276/2/be/src/service/frontend.h@129
PS2, Line 129:   /// be set to the user's current session. If this is an Impala 
internal request,
> Fix comment regarding "Impala internal calls". We should pass a const& TSes
Done


http://gerrit.cloudera.org:8080/#/c/9276/2/common/thrift/Frontend.thrift
File common/thrift/Frontend.thrift:

http://gerrit.cloudera.org:8080/#/c/9276/2/common/thrift/Frontend.thrift@171
PS2, Line 171:   // enabled, only the functions this user has access to will be 
returned. If not
> Fix comment. We're not returning functions, and we don't have Impala-intern
Done


http://gerrit.cloudera.org:8080/#/c/9276/2/fe/src/main/java/org/apache/impala/analysis/DescribeTableStmt.java
File fe/src/main/java/org/apache/impala/analysis/DescribeTableStmt.java:

http://gerrit.cloudera.org:8080/#/c/9276/2/fe/src/main/java/org/apache/impala/analysis/DescribeTableStmt.java@121
PS2, Line 121:     if (path_.destColumn() != null) {
> We're missing a privilege request for the following case:
Done


http://gerrit.cloudera.org:8080/#/c/9276/2/fe/src/main/java/org/apache/impala/analysis/DescribeTableStmt.java@128
PS2, Line 128:       analyzer.registerPrivReq(new PrivilegeRequestBuilder()
> I think this request should be unconditionally registered after L119, irres
Done


http://gerrit.cloudera.org:8080/#/c/9276/2/fe/src/main/java/org/apache/impala/service/Frontend.java
File fe/src/main/java/org/apache/impala/service/Frontend.java:

http://gerrit.cloudera.org:8080/#/c/9276/2/fe/src/main/java/org/apache/impala/service/Frontend.java@805
PS2, Line 805:               .onColumn(table.getDb().getName(), 
table.getName(),colName)
> space before 'colName'
Done


http://gerrit.cloudera.org:8080/#/c/9276/2/fe/src/main/java/org/apache/impala/service/Frontend.java@812
PS2, Line 812:         filteredColumns = table.getColumnsInHiveOrder();
> // User has table-level access.
Done


http://gerrit.cloudera.org:8080/#/c/9276/2/fe/src/main/java/org/apache/impala/service/Frontend.java@815
PS2, Line 815:       filteredColumns = table.getColumnsInHiveOrder();
> // Authorization is disabled.
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/9276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic96ae184fccdc88ba970b5adcd501da1966accb9
Gerrit-Change-Number: 9276
Gerrit-PatchSet: 2
Gerrit-Owner: Adam Holley <g...@holleyism.com>
Gerrit-Reviewer: Adam Holley <g...@holleyism.com>
Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Mar 2018 18:39:57 +0000
Gerrit-HasComments: Yes

Reply via email to