Adam Holley has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9276 )

Change subject: IMPALA-6479: Update DESCRIBE to respect column privileges
......................................................................


Patch Set 4:

(2 comments)

Updated comments.

http://gerrit.cloudera.org:8080/#/c/9276/4/be/src/service/frontend.h
File be/src/service/frontend.h:

http://gerrit.cloudera.org:8080/#/c/9276/4/be/src/service/frontend.h@128
PS4, Line 128:   /// properties, and more.  If this is a user initiated 
request, it should
> This is always a user initiated request, don't think we need that comment
Done


http://gerrit.cloudera.org:8080/#/c/9276/4/fe/src/main/java/org/apache/impala/service/Frontend.java
File fe/src/main/java/org/apache/impala/service/Frontend.java:

http://gerrit.cloudera.org:8080/#/c/9276/4/fe/src/main/java/org/apache/impala/service/Frontend.java@830
PS4, Line 830:       // Filter out LOCATION and VIEW text
> remove dead filtering code
Done



--
To view, visit http://gerrit.cloudera.org:8080/9276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic96ae184fccdc88ba970b5adcd501da1966accb9
Gerrit-Change-Number: 9276
Gerrit-PatchSet: 4
Gerrit-Owner: Adam Holley <g...@holleyism.com>
Gerrit-Reviewer: Adam Holley <g...@holleyism.com>
Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Mar 2018 21:29:48 +0000
Gerrit-HasComments: Yes

Reply via email to