Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/9403 )
Change subject: IMPALA-6324: Support reading RLE-encoded boolean values in Parquet scanner ...................................................................... Patch Set 6: "I'm curious what was wrong with the decoding - I didn't see an obvious bugfix between PS3 and this patchset." It was fixed by skipping the first 4 bytes, which contained the length of the data, and caused some extra values to be inserted. see https://gerrit.cloudera.org/#/c/9403/3..4/be/src/exec/parquet-column-readers.cc As the inserted values were 0s, and the values shifted out at the end of were also 0s, the count of 0s and 1s remained correct, so the original tests didn't catch this issue. -- To view, visit http://gerrit.cloudera.org:8080/9403 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4644bf8cf5d2b7238b05076407fbf78ab5d2c14f Gerrit-Change-Number: 9403 Gerrit-PatchSet: 6 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 14 Mar 2018 15:18:10 +0000 Gerrit-HasComments: No
