Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/9403 )
Change subject: IMPALA-6324: Support reading RLE-encoded boolean values in Parquet scanner ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/9403/7/be/src/exec/parquet-column-readers.cc File be/src/exec/parquet-column-readers.cc: http://gerrit.cloudera.org:8080/#/c/9403/7/be/src/exec/parquet-column-readers.cc@190 PS7, Line 190: DCHECK_EQ(encoding_, parquet::Encoding::RLE); > I think it's better to omit the "not for 2.x" so it doesn't confuse people Thanks for the answer! As the commit message does not contain "not for 2.x", no modification is needed related to this. http://gerrit.cloudera.org:8080/#/c/9403/2/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: http://gerrit.cloudera.org:8080/#/c/9403/2/tests/query_test/test_scanners.py@649 PS2, Line 649: "testdata/data/", file_name) > For me a refactor you mentioned makes sense. Do you know the proper way of Sorry for the late answer. I would prefer to do that refactor in a separate patch, so I have created Jira for it: https://issues.apache.org/jira/browse/IMPALA-6709 -- To view, visit http://gerrit.cloudera.org:8080/9403 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4644bf8cf5d2b7238b05076407fbf78ab5d2c14f Gerrit-Change-Number: 9403 Gerrit-PatchSet: 7 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 20 Mar 2018 14:50:54 +0000 Gerrit-HasComments: Yes
