Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9614 )
Change subject: DRAFT IMPALA-5973: Provide query plan in JSON format. ...................................................................... Patch Set 1: > into JSON format, so it can be displayed in different formats (portable) I don't think this is machine-readable. We've got things like: "detailPrefix":"| ", and "totalBytes":"4.82MB", and "| limit":100, in there. Those are pretty fundamentally unfriendly, and they don't look like stable APIs. I can't intuit the original motivation here from the JIRA, but if I wanted to build a visualization of the plan in Javascript, or if I wanted to analyze many plans to look at patterns, I'd have a hard time doing this. All the *Node* and *Sink* java files are a Java, object-based representation of the plan. One potential way forward is to serialize those to Thrift, so that we have a clear, consistent schema, and then serialize that to JSON. It may be that TPlanNode is re-usable here, or it may not be. -- To view, visit http://gerrit.cloudera.org:8080/9614 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7429ac1e93a9c524233383cafd387056fcf2542d Gerrit-Change-Number: 9614 Gerrit-PatchSet: 1 Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Pranay Singh Gerrit-Comment-Date: Wed, 14 Mar 2018 17:39:15 +0000 Gerrit-HasComments: No