Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9633 )
Change subject: IMPALA-6652: Rename Data Stream Manager MemTracker ...................................................................... Patch Set 1: (2 comments) Thanks for the review. I saw your change and copied over the relevant parts to here. http://gerrit.cloudera.org:8080/#/c/9633/1/be/src/runtime/krpc-data-stream-mgr.cc File be/src/runtime/krpc-data-stream-mgr.cc: http://gerrit.cloudera.org:8080/#/c/9633/1/be/src/runtime/krpc-data-stream-mgr.cc@81 PS1, Line 81: deferred > early Done http://gerrit.cloudera.org:8080/#/c/9633/1/be/src/runtime/krpc-data-stream-mgr.cc@83 PS1, Line 83: mem_tracker_ > This should probably renamed to a more meaningful name such as " early_rpcs Done -- To view, visit http://gerrit.cloudera.org:8080/9633 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5bb72c28e8d660a6b78543dbc8b5b156e0e7c843 Gerrit-Change-Number: 9633 Gerrit-PatchSet: 1 Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Comment-Date: Wed, 14 Mar 2018 17:59:15 +0000 Gerrit-HasComments: Yes
