Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9633 )
Change subject: IMPALA-6652: Rename label of MemTracker for early RPCs ...................................................................... Patch Set 3: (2 comments) Please see PS4. http://gerrit.cloudera.org:8080/#/c/9633/3/be/src/runtime/krpc-data-stream-mgr.cc File be/src/runtime/krpc-data-stream-mgr.cc: http://gerrit.cloudera.org:8080/#/c/9633/3/be/src/runtime/krpc-data-stream-mgr.cc@137 PS3, Line 137: mem_tracker_->Release(transfer_size); > Yeah, why is this compiling? Do we have mem_tracker_ defined somewhere else It wasn't compiling, I had forgotten to copy it over from Michael's change. http://gerrit.cloudera.org:8080/#/c/9633/3/be/src/runtime/krpc-data-stream-mgr.cc@137 PS3, Line 137: mem_tracker_->Release(transfer_size); > Doesn't this need to be updated too ? Done -- To view, visit http://gerrit.cloudera.org:8080/9633 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5bb72c28e8d660a6b78543dbc8b5b156e0e7c843 Gerrit-Change-Number: 9633 Gerrit-PatchSet: 3 Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Comment-Date: Wed, 14 Mar 2018 23:37:51 +0000 Gerrit-HasComments: Yes
