Michael Brown has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9635 )

Change subject: IMPALA-6662: Make stress test resilient to hangs due to client 
crashes
......................................................................


Patch Set 3:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/9635/2/tests/stress/concurrent_select.py
File tests/stress/concurrent_select.py:

http://gerrit.cloudera.org:8080/#/c/9635/2/tests/stress/concurrent_select.py@850
PS2, Line 850:               # crashed impalads.
> I print every runners exit code at L870. So if it does hit a SIGSEGV, it wo
Sorry. LOG events to go a very large debug log. I meant the console 
(stdout/stderr), like the status report that shows Done | Running | etc.


http://gerrit.cloudera.org:8080/#/c/9635/2/tests/stress/concurrent_select.py@860
PS2, Line 860:                 increment(runner._num_queries_finished)
             :                 # Since we know that the runner crashed whi
> These values are on a per query runner basis (no '_total' prefix), so if 2
Done


http://gerrit.cloudera.org:8080/#/c/9635/2/tests/stress/concurrent_select.py@867
PS2, Line 867:             # list.
> This is the same explanation as my previous comment, so it should be fine.
Done


http://gerrit.cloudera.org:8080/#/c/9635/2/tests/stress/concurrent_select.py@1079
PS2, Line 1079:     if report.mem_limit_exceeded:
> I print the Query Runners PID in some other places, so the PID could serve
Done



--
To view, visit http://gerrit.cloudera.org:8080/9635
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10c5dc9b8c2fffc471bac2279e348bc1d1fec3b7
Gerrit-Change-Number: 9635
Gerrit-PatchSet: 3
Gerrit-Owner: Sailesh Mukil <[email protected]>
Gerrit-Reviewer: David Knupp <[email protected]>
Gerrit-Reviewer: Michael Brown <[email protected]>
Gerrit-Reviewer: Sailesh Mukil <[email protected]>
Gerrit-Comment-Date: Thu, 15 Mar 2018 17:24:36 +0000
Gerrit-HasComments: Yes

Reply via email to