Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9635 )
Change subject: IMPALA-6662: Make stress test resilient to hangs due to client crashes ...................................................................... Patch Set 5: Code-Review+1 (2 comments) I was able to follow the changes made here and they make sense to me. http://gerrit.cloudera.org:8080/#/c/9635/4/tests/stress/concurrent_select.py File tests/stress/concurrent_select.py: http://gerrit.cloudera.org:8080/#/c/9635/4/tests/stress/concurrent_select.py@373 PS4, Line 373: total_started = self._past_runners_num_queries_started > I'd rather we not add a RLock at this point, since a lot of this script may That makes sense. http://gerrit.cloudera.org:8080/#/c/9635/4/tests/stress/concurrent_select.py@528 PS4, Line 528: try: > The relationship of query runners to queries is not clear and undocumented. This code looks like it'll continue to spin them up at the given rate and only bounded by the total number of queries. Do we see a continuous increase in runners? -- To view, visit http://gerrit.cloudera.org:8080/9635 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I10c5dc9b8c2fffc471bac2279e348bc1d1fec3b7 Gerrit-Change-Number: 9635 Gerrit-PatchSet: 5 Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Comment-Date: Thu, 15 Mar 2018 23:32:13 +0000 Gerrit-HasComments: Yes
