Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/9570 )
Change subject: IMPALA-6621: Improve set lookup performance for in-predicate evaluation ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9570/1/be/src/exprs/in-predicate.h File be/src/exprs/in-predicate.h: http://gerrit.cloudera.org:8080/#/c/9570/1/be/src/exprs/in-predicate.h@359 PS1, Line 359: state->val_set.insert(GetVal<T, SetType>(state->type, *arg)); > We should change this function to use the bulk insert API to avoid N^2 beha Done -- To view, visit http://gerrit.cloudera.org:8080/9570 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifd1627d779d10a16468cc3c2d0bc26a497e048df Gerrit-Change-Number: 9570 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 16 Mar 2018 18:24:34 +0000 Gerrit-HasComments: Yes
