Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9570 )
Change subject: IMPALA-6621: Improve set lookup performance for in-predicate evaluation ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/9570/2/be/src/exprs/in-predicate.h File be/src/exprs/in-predicate.h: http://gerrit.cloudera.org:8080/#/c/9570/2/be/src/exprs/in-predicate.h@288 PS2, Line 288: /// Note: boost::unordered_set and std::binary_search performed worse based on the : /// in-predicate-benchmark this looks outdated? -- To view, visit http://gerrit.cloudera.org:8080/9570 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifd1627d779d10a16468cc3c2d0bc26a497e048df Gerrit-Change-Number: 9570 Gerrit-PatchSet: 2 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 16 Mar 2018 22:48:52 +0000 Gerrit-HasComments: Yes
