Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9584 )
Change subject: IMPALA-5980: Upgrade to LLVM 5.0.1 ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/9584/1/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: http://gerrit.cloudera.org:8080/#/c/9584/1/be/src/codegen/llvm-codegen.cc@288 PS1, Line 288: std:: Is the std:: necessary? (I probably added it, but trying to keep the codebase somewhat consistent). http://gerrit.cloudera.org:8080/#/c/9584/1/be/src/codegen/llvm-codegen.cc@292 PS1, Line 292: std::move(err), [&](llvm::ErrorInfoBase& eib) { err_string = eib.message(); }); I guess this means that errors are not propagated by the diagnostic handler now? This method seems somewhat saner but it's hard to know what the right thing to do is with some of these APIs. http://gerrit.cloudera.org:8080/#/c/9584/1/bin/bootstrap_toolchain.py File bin/bootstrap_toolchain.py: http://gerrit.cloudera.org:8080/#/c/9584/1/bin/bootstrap_toolchain.py@153 PS1, Line 153: toolchain_build_id = "34-9407149f5f" Let's make sure we don't forget this :) http://gerrit.cloudera.org:8080/#/c/9584/1/testdata/workloads/functional-query/queries/QueryTest/udf-errors.test File testdata/workloads/functional-query/queries/QueryTest/udf-errors.test: http://gerrit.cloudera.org:8080/#/c/9584/1/testdata/workloads/functional-query/queries/QueryTest/udf-errors.test@26 PS1, Line 26: Could not load binary: $FILESYSTEM_PREFIX/test-warehouse/$DATABASE_bad_udf.llInvalid bitcode signature Don't we want a space here? -- To view, visit http://gerrit.cloudera.org:8080/9584 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib0a15cb53feab89e7b35a56b67b3b30eb3e62c6b Gerrit-Change-Number: 9584 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 16 Mar 2018 22:40:06 +0000 Gerrit-HasComments: Yes
