Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/9584 )
Change subject: IMPALA-5980: Upgrade to LLVM 5.0.1 ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/9584/1/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: http://gerrit.cloudera.org:8080/#/c/9584/1/be/src/codegen/llvm-codegen.cc@288 PS1, Line 288: std:: > Is the std:: necessary? (I probably added it, but trying to keep the codeba Done. Removed here and everywhere else in the file http://gerrit.cloudera.org:8080/#/c/9584/1/be/src/codegen/llvm-codegen.cc@292 PS1, Line 292: std::move(err), [&](llvm::ErrorInfoBase& eib) { err_string = eib.message(); }); > I guess this means that errors are not propagated by the diagnostic handler LLVM is kind of weird when it comes to handling errors, it requires that your code have a diagnostic handler, a fatal error handler and the ability to handle errors returned by api calls. Failing to do either would result in a crash. http://gerrit.cloudera.org:8080/#/c/9584/1/testdata/workloads/functional-query/queries/QueryTest/udf-errors.test File testdata/workloads/functional-query/queries/QueryTest/udf-errors.test: http://gerrit.cloudera.org:8080/#/c/9584/1/testdata/workloads/functional-query/queries/QueryTest/udf-errors.test@26 PS1, Line 26: Could not load binary: $FILESYSTEM_PREFIX/test-warehouse/$DATABASE_bad_udf.llInvalid bitcode signature > Don't we want a space here? I initially left this in as the python code that verifies errors strips away newline characters. I ll put this in a new line for better readability. -- To view, visit http://gerrit.cloudera.org:8080/9584 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib0a15cb53feab89e7b35a56b67b3b30eb3e62c6b Gerrit-Change-Number: 9584 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 19 Mar 2018 18:53:44 +0000 Gerrit-HasComments: Yes
