Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9525 )
Change subject: IMPALA-6389: Make '\0' delimited text files work ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/9525/3/be/src/exec/delimited-text-parser.h File be/src/exec/delimited-text-parser.h: http://gerrit.cloudera.org:8080/#/c/9525/3/be/src/exec/delimited-text-parser.h@174 PS3, Line 174: field_delim_ != tuple_delim_ > hmm, okay. this seems a bit weird to me to handle cases (and have to think I'm not super happy about this, as I found the can of worms during testing. The tests now exercise pretty much all of the cases, both valid and invalid. I did not extend the tests to validate sequence file parsing (we have no tests for this). Mostly, I am concerned with just not crashing and having well defined behavior in all cases, no matter what, even if we get nonsensical metadata for the file. http://gerrit.cloudera.org:8080/#/c/9525/3/be/src/exec/delimited-text-parser.cc File be/src/exec/delimited-text-parser.cc: http://gerrit.cloudera.org:8080/#/c/9525/3/be/src/exec/delimited-text-parser.cc@182 PS3, Line 182: if (DELIMITED_TUPLES) unfinished_tuple_ = false; > I don't think we need to code it explicitly. My comment about DCHECK is to Done -- To view, visit http://gerrit.cloudera.org:8080/9525 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4b6f38cbe3f1036f60efd31a31d82d0cd8f3d2a8 Gerrit-Change-Number: 9525 Gerrit-PatchSet: 3 Gerrit-Owner: Zach Amsden <zams...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zach Amsden <zams...@cloudera.com> Gerrit-Comment-Date: Wed, 21 Mar 2018 20:54:07 +0000 Gerrit-HasComments: Yes
