Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9690 )
Change subject: IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/9690/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9690/1//COMMIT_MSG@48 PS1, Line 48: DeferredBatches > Actually, after some more thought, this should stay non-cumulative. The rea Should we rename it to DeferredBatchQueueSize or DeferredQueueSize or DeferredBatchesGauge to express that it is non-cummulative? http://gerrit.cloudera.org:8080/#/c/9690/1/be/src/runtime/krpc-data-stream-recvr.h File be/src/runtime/krpc-data-stream-recvr.h: http://gerrit.cloudera.org:8080/#/c/9690/1/be/src/runtime/krpc-data-stream-recvr.h@263 PS1, Line 263: /// Total wall-clock time of row batches spent in deferred queue before being processed. : RuntimeProfile::Counter* deferred_queue_time_; > Looked into using histogram. Seems a bit painful to report the histogram pe Thanks for the explanation. In that case we might want to add Histogram counters to the profiles but that's better left to a follow up change. http://gerrit.cloudera.org:8080/#/c/9690/1/be/src/runtime/krpc-data-stream-recvr.h@292 PS1, Line 292: RuntimeProfile::Counter* producer_wait_time_; > I believe all RuntimeProfile::Counters members which measure time don't act Thanks for the explanation. http://gerrit.cloudera.org:8080/#/c/9690/1/be/src/runtime/krpc-data-stream-recvr.cc File be/src/runtime/krpc-data-stream-recvr.cc: http://gerrit.cloudera.org:8080/#/c/9690/1/be/src/runtime/krpc-data-stream-recvr.cc@639 PS1, Line 639: TotalBatchesDeferred > 'total_early_senders_' above is for that. But that is the number of hosts arriving early, not the number of batches arriving early, no? Can we have both? If not, should we use number of batches for both? -- To view, visit http://gerrit.cloudera.org:8080/9690 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8ba405921b3df920c1e85b940ce9c8d02fc647cd Gerrit-Change-Number: 9690 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Comment-Date: Wed, 21 Mar 2018 22:11:38 +0000 Gerrit-HasComments: Yes
