Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9690 )
Change subject: IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/9690/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9690/1//COMMIT_MSG@48 PS1, Line 48: DeferredBatches > Should we rename it to DeferredBatchQueueSize or DeferredQueueSize or Defer Done http://gerrit.cloudera.org:8080/#/c/9690/1/be/src/runtime/krpc-data-stream-recvr.cc File be/src/runtime/krpc-data-stream-recvr.cc: http://gerrit.cloudera.org:8080/#/c/9690/1/be/src/runtime/krpc-data-stream-recvr.cc@639 PS1, Line 639: TotalBatchesDeferred > But that is the number of hosts arriving early, not the number of batches a Since we let one pending RPC per sender to a given exchange node instance at a time, this should be the same as the number of "hosts" if you only count the fragment instances sending to this exchange node. Of course, there could be multiple queries running on the remote host so different fragment instances for the same or different queries could arrive early but not sure if they are too meaningful to track outside of query profile. Please let me know if I misunderstood your concern. -- To view, visit http://gerrit.cloudera.org:8080/9690 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8ba405921b3df920c1e85b940ce9c8d02fc647cd Gerrit-Change-Number: 9690 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Mostafa Mokhtar <mmokh...@cloudera.com> Gerrit-Comment-Date: Thu, 22 Mar 2018 00:34:00 +0000 Gerrit-HasComments: Yes
