Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/9716 )
Change subject: IMPALA-4277: Support multiple versions of Hadoop ecosystem ...................................................................... Patch Set 10: (3 comments) You can safely ignore my comments. Let's try to get this out first and I can work on cleaning up the privilege model in a different patch. http://gerrit.cloudera.org:8080/#/c/9716/8/fe/src/compat-minicluster-profile-3/java/org/apache/impala/authorization/ImpalaActionFactory.java File fe/src/compat-minicluster-profile-3/java/org/apache/impala/authorization/ImpalaActionFactory.java: http://gerrit.cloudera.org:8080/#/c/9716/8/fe/src/compat-minicluster-profile-3/java/org/apache/impala/authorization/ImpalaActionFactory.java@32 PS8, Line 32: SELECT(AccessConstants.SELECT, 1), > Fredy and I talked about this, and I've not done this right now. He's plann Please ignore this. We should work on it in a separate JIRA. http://gerrit.cloudera.org:8080/#/c/9716/8/fe/src/compat-minicluster-profile-3/java/org/apache/impala/authorization/ImpalaActionFactory.java@37 PS8, Line 37: INDEX(AccessConstants.INDEX, 32), > Similarly, I'm not doing this quite yet. Please ignore this. We should work on it in a separate JIRA. http://gerrit.cloudera.org:8080/#/c/9716/8/fe/src/compat-minicluster-profile-3/java/org/apache/impala/authorization/ImpalaActionFactory.java@67 PS8, Line 67: return null; > Again: I've not done this yet, to avoid doing too much in this change. Please ignore this. We should work on it in a separate JIRA. -- To view, visit http://gerrit.cloudera.org:8080/9716 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7a2ab50331986c7394c2bbfd6c865232bca975f7 Gerrit-Change-Number: 9716 Gerrit-PatchSet: 10 Gerrit-Owner: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 22 Mar 2018 22:12:19 +0000 Gerrit-HasComments: Yes
