Vincent Tran has posted comments on this change. ( http://gerrit.cloudera.org:8080/9725 )
Change subject: IMPALA-6641: Support more separators between date and time in default timestamp format ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9725/1/be/src/runtime/timestamp-parse-util.cc File be/src/runtime/timestamp-parse-util.cc: http://gerrit.cloudera.org:8080/#/c/9725/1/be/src/runtime/timestamp-parse-util.cc@407 PS1, Line 407: if (str[4] == '-' && str[7] == '-' && str[13] == ':') { > Checking str[13] here doesn't seem right - that will read past the end of t Good point. -- To view, visit http://gerrit.cloudera.org:8080/9725 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id2ce3ba09256b3996170e42d42d49d12776cab97 Gerrit-Change-Number: 9725 Gerrit-PatchSet: 1 Gerrit-Owner: Vincent Tran <vtt...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Vincent Tran <vtt...@cloudera.com> Gerrit-Comment-Date: Fri, 23 Mar 2018 09:47:49 +0000 Gerrit-HasComments: Yes
