Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9725 )
Change subject: IMPALA-6641: Support more separators between date and time in default timestamp format ...................................................................... Patch Set 2: (2 comments) LGTM once these two things are fixed. http://gerrit.cloudera.org:8080/#/c/9725/2/be/src/runtime/timestamp-parse-util.cc File be/src/runtime/timestamp-parse-util.cc: http://gerrit.cloudera.org:8080/#/c/9725/2/be/src/runtime/timestamp-parse-util.cc@422 PS2, Line 422: break; Break needs to go outside if, otherwise we'll fall through to the next case when str[13] is != ":". http://gerrit.cloudera.org:8080/#/c/9725/2/be/src/runtime/timestamp-parse-util.cc@435 PS2, Line 435: break; Same here. -- To view, visit http://gerrit.cloudera.org:8080/9725 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id2ce3ba09256b3996170e42d42d49d12776cab97 Gerrit-Change-Number: 9725 Gerrit-PatchSet: 2 Gerrit-Owner: Vincent Tran <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vincent Tran <[email protected]> Gerrit-Comment-Date: Fri, 23 Mar 2018 15:20:43 +0000 Gerrit-HasComments: Yes
