Fredy Wijaya has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/9800 )
Change subject: IMPALA-6724: Incorrect exception handling in create function statement ...................................................................... IMPALA-6724: Incorrect exception handling in create function statement This patch removes restriction on creating a function with the same name as the built-in function. The reason for doing this is to avoid name clash when introducing new built-in functions. Existing behavior: > use mydb; > create function sin(double) ... -- this is not allowed New behavior: > use mydb; > create function sin(double) ... -- this is allowed Existing behavior: > create function _impala_builtins.sin(double) ... -- same name exception New behavior: > create function _impala_builtins.sin(double) ... -- cannot modify system database exception Testing: - Ran front-end tests Change-Id: Ic30df56ac276970116715c14454a5a2477b185fa --- M fe/src/main/java/org/apache/impala/analysis/CreateFunctionStmtBase.java M fe/src/main/java/org/apache/impala/analysis/FunctionName.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java M fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java 4 files changed, 48 insertions(+), 19 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/9800/3 -- To view, visit http://gerrit.cloudera.org:8080/9800 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic30df56ac276970116715c14454a5a2477b185fa Gerrit-Change-Number: 9800 Gerrit-PatchSet: 3 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com>
