Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/9800 )
Change subject: IMPALA-6724: Incorrect exception handling in create function statement ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/9800/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9800/2//COMMIT_MSG@13 PS2, Line 13: Testing: Looks to me like a compat-breaking change, add that to the commit message and not to cherry-pick to 2.x? Just curious if everyone is ok with this approach. Vuk/Alex? One concerning thing is that if some user overrides an inbuilt function with a custom behavior and other users don't know that, that could result in unexpected results. Thoughts? http://gerrit.cloudera.org:8080/#/c/9800/2/fe/src/main/java/org/apache/impala/analysis/CreateFunctionStmtBase.java File fe/src/main/java/org/apache/impala/analysis/CreateFunctionStmtBase.java: http://gerrit.cloudera.org:8080/#/c/9800/2/fe/src/main/java/org/apache/impala/analysis/CreateFunctionStmtBase.java@137 PS2, Line 137: fnName_.analyze(analyzer, true); Should you update other places that resolve functions (like DropStmt for example) to reflect the same behavior? Else, I guess it might be confusing if create/drop/selects resolve functions their own ways. I haven't tried the patch locally, but looks like it could happen? -- succeeds use mydb; create function sin(... --- select sin() <-- what should this resolve to, given we have both mydb.sin() and inbuilt.sin() -- fails drop function sin(... can't modify system db... -- To view, visit http://gerrit.cloudera.org:8080/9800 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic30df56ac276970116715c14454a5a2477b185fa Gerrit-Change-Number: 9800 Gerrit-PatchSet: 2 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Mon, 26 Mar 2018 18:13:30 +0000 Gerrit-HasComments: Yes
