Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9805 )
Change subject: IMPALA-6649: Add fine-grained ALTER privilege ...................................................................... Patch Set 3: (2 comments) Answered questions. http://gerrit.cloudera.org:8080/#/c/9805/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9805/3//COMMIT_MSG@29 PS3, Line 29: Cherry-picks: not for 2.x > nit: usually cherry-picks is before Change-Id I think I had it before and it switched it. http://gerrit.cloudera.org:8080/#/c/9805/3/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java File fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java: http://gerrit.cloudera.org:8080/#/c/9805/3/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java@1616 PS3, Line 1616: AuthzError("alter view functional.alltypes_view_sub as " + > What's the reason for changing this to alltypes_view_sub? Originally added view_view ALTER privileges for all the new tests, but required a lot of test changes because they assumed that privilege was not there. Adding alltypes_view was simpler, but because of that, had to change these couple to alltypes_view_sub. -- To view, visit http://gerrit.cloudera.org:8080/9805 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0b25d10a8634829fbe90e308dfc7efc8182fef2d Gerrit-Change-Number: 9805 Gerrit-PatchSet: 3 Gerrit-Owner: Adam Holley <[email protected]> Gerrit-Reviewer: Adam Holley <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Comment-Date: Tue, 27 Mar 2018 16:04:09 +0000 Gerrit-HasComments: Yes
