Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9805 )
Change subject: IMPALA-6649: Add fine-grained ALTER privilege ...................................................................... Patch Set 4: (7 comments) http://gerrit.cloudera.org:8080/#/c/9805/4/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java File fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java: http://gerrit.cloudera.org:8080/#/c/9805/4/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java@1400 PS4, Line 1400: > remove newline (it seems to make no sense) Done http://gerrit.cloudera.org:8080/#/c/9805/4/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java@1409 PS4, Line 1409: AuthzOk("ALTER TABLE functional.table_no_newline_part RENAME TO functional_seq_snap.t1"); > Add a negative case where the user doesn't have CREATE on the target DB. Or Added new test around 1524. seemed to go with the existing "no privileges on target". http://gerrit.cloudera.org:8080/#/c/9805/4/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java@1418 PS4, Line 1418: > remove newline Done http://gerrit.cloudera.org:8080/#/c/9805/4/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java@1422 PS4, Line 1422: // Alter table and set location to a path the user does not have access to. > Mention what is needed here. ALL on the URI? Done http://gerrit.cloudera.org:8080/#/c/9805/4/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java@1575 PS4, Line 1575: AuthzOk("ALTER VIEW functional.alltypes_view rename to functional_seq_snap.view_view_1"); > Also add negative test where user doesn't have CREATE on the target DB (or New test around 1582. http://gerrit.cloudera.org:8080/#/c/9805/4/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java@2705 PS4, Line 2705: > remove newline Done http://gerrit.cloudera.org:8080/#/c/9805/4/fe/src/test/resources/authz-policy.ini.template File fe/src/test/resources/authz-policy.ini.template: http://gerrit.cloudera.org:8080/#/c/9805/4/fe/src/test/resources/authz-policy.ini.template@31 PS4, Line 31: alter_functional_table_no_newline_part, alter_functional_alltypes_view,\ > table_no_newline_part is a really odd table, can we use a more "regular" ta Done. -- To view, visit http://gerrit.cloudera.org:8080/9805 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0b25d10a8634829fbe90e308dfc7efc8182fef2d Gerrit-Change-Number: 9805 Gerrit-PatchSet: 4 Gerrit-Owner: Adam Holley <[email protected]> Gerrit-Reviewer: Adam Holley <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Comment-Date: Fri, 30 Mar 2018 05:14:51 +0000 Gerrit-HasComments: Yes
